Only show existing columns in message storage views #8676
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lumns-in-messagestore-when-using-jdbctablelistener # Conflicts: # console/backend/src/main/java/org/frankframework/console/controllers/TransactionalStorage.java
philipsens
approved these changes
Apr 2, 2025
There was a problem hiding this comment.
Copilot reviewed 14 out of 19 changed files in this pull request and generated no comments.
Files not reviewed (5)
- console/frontend/src/main/frontend/src/app/views/storage/storage-view/storage-view.component.html: Language not supported
- console/frontend/src/main/frontend/src/app/views/storage/storage-view/storage-view.component.scss: Language not supported
- core/src/test/resources/Management/MessageBrowserFindAll.json: Language not supported
- core/src/test/resources/Management/MessageBrowserFindNone.json: Language not supported
- core/src/test/resources/Management/MessageBrowserFindOne.json: Language not supported
Comments suppressed due to low confidence (1)
messaging/src/main/java/org/frankframework/jms/AbstractJmsMessageBrowser.java:227
- The use of 'null' as the fieldName may be confusing especially if it is used in filtering or matching logic later. Consider using a concrete identifier or adding a comment to clarify the intent.
new MessageBrowserField(null, "id", "Storage ID", "string"),
…lumns-in-messagestore-when-using-jdbctablelistener
nielsm5
reviewed
Apr 14, 2025
| request.setHeader(BusMessageUtils.HEADER_CONFIGURATION_NAME_KEY, getConfiguration().getName()); | ||
| request.setHeader(BusMessageUtils.HEADER_ADAPTER_NAME_KEY, adapter.getName()); | ||
| try { | ||
| callSyncGateway(request); |
There was a problem hiding this comment.
als je hier een exceptie verwacht moet je assertThrows gebruiken, als je hier nu geen exceptie krijgt gaat de test nog steeds goed.
| new MessageBrowserField(getExpiryDateField(), "expiryDate", "Expires", "date"), | ||
| new MessageBrowserField(getCommentField(), "comment", "Comment", "string"), | ||
| new MessageBrowserField(getLabelField(), "label", "Label", "string") | ||
| ).filter(field -> field.fieldName() != null).toList(); |
…showing-not-existing-columns-in-messagestore-when-using-jdbctablelistener
nielsm5
approved these changes
Apr 17, 2025
nielsm5
approved these changes
Apr 17, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.