Turn a panicking cmp.Diff into a bad check #154
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using Not(DeepEquals) on a type with an unexported field currently succeeds without an error. This is because the unexported field is raised as a panic by go-cmp, which is turned into a plain error by the library. Not then interprets the error to mean "not equal" instead of forwarding it to the user. Fix this by turning any go-cmp panics into a bad check. Fixes frankban#153
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using Not(DeepEquals) on a type with an unexported field currently succeeds without an error. This is because the unexported field is raised as a panic by go-cmp, which is turned into a plain error by the library. Not then interprets the error to mean "not equal" instead of forwarding it to the user.
Fix this by turning any go-cmp panics into a bad check.
Fixes #153