Skip to content

fix: finish running animations - closes #12044 #12045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from Apr 8, 2020
Merged

fix: finish running animations - closes #12044 #12045

merged 1 commit into from Apr 8, 2020

Conversation

DanielRuf
Copy link
Contributor

Description

This Pr fixes the regression caused by using stop() instead of finish().

Types of changes

  • Documentation
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (anything that would change an existing functionality)
  • Maintenance (refactor, code cleaning, development tools...)

Checklist

  • I have read and follow the CONTRIBUTING.md document.
  • The pull request title and template are correctly filled.
  • The pull request targets the right branch (develop or develop-v...).
  • My commits are correctly titled and contain all relevant information.
  • I have updated the documentation accordingly to my changes (if relevant).
  • I have added tests to cover my changes (if relevant).

@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 8, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@DanielRuf DanielRuf requested a review from joeworkman April 8, 2020 16:02
@DanielRuf
Copy link
Contributor Author

@joeworkman we need a new release then as this fixes some issues caused by the last release.

@joeworkman
Copy link
Member

Sure. do we need any others besides this one?

@DanielRuf
Copy link
Contributor Author

Probably just this one here. Not sure about the download link #12042 as the current zip download link throws an error.

joeworkman
joeworkman approved these changes Apr 8, 2020
View reviewed changes
Copy link
Member

@joeworkman joeworkman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was not aware of .finish(). that is definitely better.

@joeworkman
Copy link
Member

Do we want to get the browserstack build working?

@DanielRuf
Copy link
Contributor Author

Do we want to get the browserstack build working?

It works / runs after the merge ;-)
GitHub does not share the secrets with forks which is ok that it fails here. This is why we also should have master and develop for releases. So it will run on develop after this. And when you do a new release it should be fine then.

@joeworkman
Copy link
Member

OK. So we want to release 6.6.3 with just this and the download fix?

@DanielRuf
Copy link
Contributor Author

Exactly.

@joeworkman joeworkman merged commit 33d9579 into foundation:develop Apr 8, 2020
@DanielRuf DanielRuf deleted the fix/12044-accordion-finish-running-animations branch April 8, 2020 18:12
@joeworkman
Copy link
Member

This pull request has been mentioned on Foundation Open Source Community. There might be relevant details there:

https://foundation.discourse.group/t/foundation-v6-6-3-released/2095/1

@iamsuganthi iamsuganthi mentioned this pull request Aug 6, 2024
Open
@AliceSof AliceSof mentioned this pull request Aug 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joeworkman joeworkman joeworkman approved these changes

Assignees
No one assigned
Labels
Accordion javascript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug][6.6.2] Accordion height for pre "is-active" accordion item not correct
2 participants
@DanielRuf @joeworkman