Skip to content

#468 fix DeprecationWarning: Calling promisify on a function that returns a Promise is likely a mistake. #471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 5, 2025
Merged

#468 fix DeprecationWarning: Calling promisify on a function that returns a Promise is likely a mistake. #471

merged 1 commit into from
Jun 5, 2025

Conversation

ddequidt
Copy link
Contributor

fix DeprecationWarning: Calling promisify on a function that returns a Promise is likely a mistake.

Checklist

  • [X ] I have ensured my pull request is not behind the main or master branch of the original repository.
  • [X ] I have rebased all commits where necessary so that reviewing this pull request can be done without having to merge it first.
  • [X ] I have written a commit message that passes commitlint linting.
  • [X ] I have ensured that my code changes pass linting tests.
  • [X ] I have ensured that my code changes pass unit tests.
  • [X ] I have described my pull request and the reasons for code changes along with context if necessary.

@ddequidt
forwardemail#468 fix DeprecationWarning: Calling promisify on a funct…
dec0a3b 
…ion that returns a Promise is likely a mistake.
ryanlelek
ryanlelek approved these changes May 26, 2025
View reviewed changes
Copy link

@ryanlelek ryanlelek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I'm not part of the project)

Thanks for submitting, I reviewed and this looks good
I'm facing the same issue on Node v22.16.0

Giving a +1 for when the maintainers can review

@quiddle
Copy link

quiddle commented May 27, 2025

Another +1 for this PR. Everything worked fine in my testing on Node 22.13.1

@daniel5150
Copy link

@titanism any chance to review this PR?

@titanism titanism merged commit 97080bd into forwardemail:master Jun 5, 2025
3 checks passed
@titanism
Copy link
Contributor

titanism commented Jun 5, 2025

Sorry for the delay, we've been super heads down on new features at @forwardemail.

Thanks for the PR and the friendly bump.

Merged and released to npm 🙏

v12.0.3 released to npm and GitHub releases

https://github.com/forwardemail/email-templates/releases/tag/v12.0.3

@titanism titanism mentioned this pull request Jun 5, 2025
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@ryanlelek ryanlelek ryanlelek approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ddequidt @quiddle @daniel5150 @titanism @ryanlelek