[metapackage] MPI: add SLURM srun as tentative MPI runner
#1141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rouson
approved these changes
May 16, 2025
|
@perazz thanks so much for this! I'm working on a deadline today, but will try to find time to test this soon. It certainly sounds to me like a good solution so feel free to merge it without waiting for me if you like. Alternatively, I'd be happy to evaluate this in a pair programming session next week if you like. |
perazz
commented
May 16, 2025
|
Thank you for the review @rouson. I agree: because of the simple PR, I will merge this so that it can be battletested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address #1140
@rouson: as I have no way to test this addition: do you think it will be enough to just add
srunto the list of tentative MPI runners? Maybe in the future we will be able to attempt to build and run a simple program on-the-fly and try to run it with introspection, but it's not currently possible right now.