You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR introduces a bug fix to attach a fpm_model.json file , this bug has been patched in an interim manner in the registry repo: fortran-lang/registry#75 .
@gnikit No, The git_archive functionality is only used to publish a tarball to the registry. This bug doesn't affect any other fpm functionality. the tarball uploaded on the registry must contain a fpm_model.json file, which was not getting attached in v0.10.1 to handle this in an interim manner a patch fortran-lang/registry#75 has been made on the registry side to generate and attach the fpm_model.json file to the tarball on the server side, This is a permanent fix for the bug.
My edit reflects @gnikit (and my) concern to not lose the option to call git_archive from elsewhere. LGTM with this edit, let's see what Giannis thinks.
henilp105
changed the title
fix: add fpm_model.json to the package tarball before uploading to this registry.
fix: add fpm_model.json to the package tarball before uploading to the registry
Mar 25, 2024
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a bug fix to attach a
fpm_model.jsonfile , this bug has been patched in an interim manner in the registry repo: fortran-lang/registry#75 .Thanks and Regards,
Henil