Skip to content

Fpm release v0.9.0 #922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 2, 2023
Merged

Fpm release v0.9.0 #922

merged 4 commits into from
Jun 2, 2023

Conversation

perazz
Copy link
Member

@perazz perazz commented Jun 1, 2023

@perazz perazz requested review from arteevraina, awvwgk and minhqdao June 1, 2023 17:40
awvwgk
awvwgk requested changes Jun 2, 2023
View reviewed changes
awvwgk
awvwgk requested changes Jun 2, 2023
View reviewed changes
Copy link
Member

@awvwgk awvwgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This introduces a new change for MPI, I would prefer to have last minute feature additions as separate patch.

@perazz
Copy link
Member Author

perazz commented Jun 2, 2023 •
edited
Loading

Yes, the MS-MPI CI seldom does not read %MSMPI_BIN% and fails, the logs are not helpful but it may be due to it using the Git Bash shell. This never happens in my local and docker tests. the procedure looks like:

  1. look for mpiexec.exe in %MSMPI_BIN%
  2. not found? search in %PATH% by running where mpiexec.exe, where mpirun.exe, and which mpiexec.exe which mpirun.exe (which work on WSL)

The CI shows that it's those commands that do not work, even if the Microsoft MPI folder is actually in %PATH%: i.e. from the last failed CI

which: no mpiexec.exe in (/mingw64/bin:/usr/bin:/c/Users/runneradmin/bin:/d/a/_temp:/c/Program Files/Microsoft MPI/Bin:/d/a/_temp/msys64/mingw64/bin:/d/a/_temp/setup-msys2:/c/Program Files/MongoDB/Server/5.0/bin:/c/aliyun-cli:/c/vcpkg:/c/Program Files (x86)/NSIS:/c/tools/zstd:/c/Program Files/Mercurial:/c/hostedtoolcache/windows/stack/2.9.3/x64:/c/cabal/bin:/c/ghcup/bin:/c/Program Files/dotnet:/c/mysql/bin:/c/Program Files/R/R-4.3.0/bin/x64:/c/SeleniumWebDrivers/GeckoDriver:/c/Program Files (x86)/sbt/bin:/c/Program Files (x86)/GitHub CLI:/usr/bin:/c/Program Files (x86)/pipx_bin:/c/npm/prefix:/c/hostedtoolcache/windows/go/1.20.4/x64/bin:/c/hostedtoolcache/windows/Python/3.9.13/x64/Scripts:/c/hostedtoolcache/windows/Python/3.9.13/x64:/c/hostedtoolcache/windows/Ruby/3.0.6/x64/bin:/c/Program Files/OpenSSL/bin:/c/tools/kotlinc/bin:/c/hostedtoolcache/windows/Java_Temurin-Hotspot_jdk/8.0.372-7/x64/bin:/c/Program Files/ImageMagick-7.1.1-Q16-HDRI:/c/Program Files (x86)/Microsoft SDKs/Azure/CLI2/wbin:/c/ProgramData/kind:/c/Program Files/Microsoft/jdk-11.0.16.101-hotspot/bin:/c/Windows/system32:/c/Windows:/c/Windows/System32/Wbem:/c/Windows/System32/WindowsPowerShell/v1.0:/c/Windows/System32/OpenSSH:/c/Program Files/dotnet:/c/ProgramData/Chocolatey/bin:/c/Program Files/PowerShell/7:/c/Program Files/Microsoft/Web Platform Installer:/c/Program Files/Microsoft SQL Server/Client SDK/ODBC/170/Tools/Binn:/c/Program Files/Microsoft SQL Server/150/Tools/Binn:/c/Strawberry/c/bin:/c/Strawberry/perl/site/bin:/c/Strawberry/perl/bin:/c/ProgramData/chocolatey/lib/pulumi/tools/Pulumi/bin:/c/Program Files/TortoiseSVN/bin:/c/Program Files/CMake/bin:/c/ProgramData/chocolatey/lib/maven/apache-maven-3.8.7/bin:/c/Program Files/Microsoft Service Fabric/bin/Fabric/Fabric.Code:/c/Program Files/Microsoft SDKs/Service Fabric/Tools/ServiceFabricLocalClusterManager:/c/Program Files/nodejs:/cmd:/mingw64/bin:/usr/bin:/c/Program Files/GitHub CLI:/c/tools/php:/c/Program Files (x86)/sbt/bin:/c/SeleniumWebDrivers/ChromeDriver:/c/SeleniumWebDrivers/EdgeDriver:/c/Program Files/Amazon/AWSCLIV2:/c/Program Files/Amazon/SessionManagerPlugin/bin:/c/Program Files/Amazon/AWSSAMCLI/bin:/c/Program Files/Microsoft SQL Server/130/Tools/Binn:/c/Program Files/LLVM/bin:/c/Users/runneradmin/.dotnet/tools:/c/Users/runneradmin/.cargo/bin:/c/Users/runneradmin/AppData/Local/Microsoft/WindowsApps)

The MPI path is actually in %PATH% but as /c/Program Files/Microsoft MPI/Bin, not C:\Program Files\Microsoft MPI\Bin, so it's possible that searching for the latter does not work under the Bash CI? But if so, why does it only happen every now and then? It may have to do with the version of the github action runner?

Anyways I will stash that commit for now

awvwgk
awvwgk approved these changes Jun 2, 2023
View reviewed changes
Copy link
Member

@awvwgk awvwgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now

@awvwgk awvwgk merged commit c7c421a into fortran-lang:main Jun 2, 2023
@awvwgk
Copy link
Member

awvwgk commented Jun 2, 2023

Thanks for the clarification.

@perazz perazz mentioned this pull request Oct 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awvwgk awvwgk awvwgk approved these changes

@arteevraina arteevraina Awaiting requested review from arteevraina

@minhqdao minhqdao Awaiting requested review from minhqdao

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fpm 0.9.0 release
2 participants
@perazz @awvwgk