Skip to content

Fix --show-package-version #887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 22, 2023
Merged

Fix --show-package-version #887

merged 1 commit into from
Apr 22, 2023

Conversation

minhqdao
Copy link
Contributor

@minhqdao minhqdao commented Apr 21, 2023 •
edited
Loading

fpm publish --show-package-version isn't working because I accidentally deleted the relevent lines in 3b1bf31. This is being fixed here.

How to test

  • Install and run fpm publish --show-package-version.

arteevraina
arteevraina approved these changes Apr 22, 2023
View reviewed changes
Copy link
Member

@arteevraina arteevraina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @minhqdao

@minhqdao
Copy link
Contributor Author

Thanks @minhqdao

Thank you, @arteevraina

@minhqdao minhqdao merged commit ce6047c into main Apr 22, 2023
@minhqdao minhqdao deleted the fix-show-package-version branch April 22, 2023 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arteevraina arteevraina arteevraina approved these changes

@henilp105 henilp105 Awaiting requested review from henilp105

@perazz perazz Awaiting requested review from perazz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@minhqdao @arteevraina