Skip to content

Release 0.8.1 #874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 12, 2023
Merged

Release 0.8.1 #874

merged 7 commits into from
Apr 12, 2023

Conversation

perazz
Copy link
Member

@perazz perazz commented Apr 11, 2023

@urbanjost
Copy link
Contributor

It has quit rebuilding but still pulls down each dependency. Up to 0.7.0 if I did a build and then turned off my network I could still
rebuild as long as I did not remove the dependencies. Now, even though this project is completely built all remote dependencies
are pulled. If the network is not reachable I cannot rebuild without moving all the files to project subdirectories and changing the fpm.toml file to use local packages. This occurs on any Linux system I tried. So the actual recompilation is gone but not the pull.
I can duplicate this with just

https://github.com/urbanjost/M_strings

@mercury:~/github/M_strings$ fpm build

Update: M_msg

Reinitialized existing Git repository in /home/urbanjs/venus/V600/github/M_strings/build/dependencies/M_msg/.git/
remote: Enumerating objects: 275, done.
remote: Counting objects: 100% (275/275), done.
remote: Compressing objects: 100% (140/140), done.
remote: Total 275 (delta 147), reused 221 (delta 131), pack-reused 0
Receiving objects: 100% (275/275), 1.14 MiB | 2.65 MiB/s, done.
Resolving deltas: 100% (147/147), done.
From https://github.com/urbanjost/M_msg

  • branch HEAD -> FETCH_HEAD
    Project is up to date
    @mercury:~/github/M_strings$ fpm build

Update: M_msg

Reinitialized existing Git repository in /home/urbanjs/venus/V600/github/M_strings/build/dependencies/M_msg/.git/
fatal: unable to access 'https://github.com/urbanjost/M_msg.git/': Could not resolve host: github.com
cmd_build Model error: Error while fetching git repository for remote dependency

@perazz
Copy link
Member Author

perazz commented Apr 11, 2023

@urbanjost I cannot reproduce this issue: on my system (macOS + gfortran-12), I have:

federico@Federicos-MacBook-Pro M_strings % fpmx build
 + mkdir -p build/dependencies
Initialized empty Git repository in /Users/federico/Documents/GitHub/M_strings/build/dependencies/M_msg/.git/
[...]
demo_rpad                              done.
[100%] Project compiled successfully.
federico@Federicos-MacBook-Pro M_strings % fpmx build
Project is up to date
federico@Federicos-MacBook-Pro M_strings % fpmx build
Project is up to date
federico@Federicos-MacBook-Pro M_strings % fpmx update
federico@Federicos-MacBook-Pro M_strings % 

Is it possible that other compilers (or versions thereof) have problems with the way some of the equality comparisons are made? Strings from cache.toml are just compared as string1==string2 but maybe there are caveats with trailing spaces / new line characters? There should not be as far as the TOML is properly loaded (which it is).

Copy link
Member

@everythingfunctional everythingfunctional left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm good with this for now. If @urbanjost has workflows where he needs to be able to continue building without network, it may be worth waiting until that is sorted out though.

@everythingfunctional
Copy link
Member

My guess is you will actually need 2 flags when you're building up the dependency list.

  1. Is this the cached version?
  2. Is this the first time I'm encountering this dependency

That way you only update the dependency if it doesn't match the cached version and it is the first version encountered when walking the tree.

@perazz
Copy link
Member Author

perazz commented Apr 11, 2023

Aaah I think I found where the issue is from. Commit 1f604b4 introduced undefined behavior (removed fetch=.false. by default) in dependency%register, apparently in all the tests I've made so far that was always .true. by complete chance!

@perazz
Copy link
Member Author

perazz commented Apr 11, 2023

Brad @everythingfunctional what should I do with this bugfix? merge into my release branch directly, or open a new PR on fpm main?

@everythingfunctional
Copy link
Member

Brad @everythingfunctional what should I do with this bugfix? merge into my release branch directly, or open a new PR on fpm main?

Proper procedure would probably be to do a separate PR, and then rebase this one once that's been merged.

@perazz perazz marked this pull request as draft April 11, 2023 16:55
@perazz perazz merged commit 85af013 into fortran-lang:main Apr 12, 2023
@perazz perazz deleted the release_0.8.1 branch April 12, 2023 06:49
@perazz
Copy link
Member Author

perazz commented Apr 12, 2023

Release suspended due to #875, will open a new PR for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants