-
Notifications
You must be signed in to change notification settings - Fork 111
Release 0.8.1 #874
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 0.8.1 #874
Conversation
It has quit rebuilding but still pulls down each dependency. Up to 0.7.0 if I did a build and then turned off my network I could still https://github.com/urbanjost/M_strings @mercury:~/github/M_strings$ fpm build Update: M_msgReinitialized existing Git repository in /home/urbanjs/venus/V600/github/M_strings/build/dependencies/M_msg/.git/
Update: M_msgReinitialized existing Git repository in /home/urbanjs/venus/V600/github/M_strings/build/dependencies/M_msg/.git/ |
@urbanjost I cannot reproduce this issue: on my system (macOS + gfortran-12), I have:
Is it possible that other compilers (or versions thereof) have problems with the way some of the equality comparisons are made? Strings from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm good with this for now. If @urbanjost has workflows where he needs to be able to continue building without network, it may be worth waiting until that is sorted out though.
My guess is you will actually need 2 flags when you're building up the dependency list.
That way you only update the dependency if it doesn't match the cached version and it is the first version encountered when walking the tree. |
Aaah I think I found where the issue is from. Commit 1f604b4 introduced undefined behavior (removed |
Brad @everythingfunctional what should I do with this bugfix? merge into my release branch directly, or open a new PR on fpm main? |
Proper procedure would probably be to do a separate PR, and then rebase this one once that's been merged. |
Release suspended due to #875, will open a new PR for that. |
Test release at https://github.com/perazz/fpm/releases/tag/v0.8.1
Announcement at fortran-lang/fpm-docs#101
cf. #872