fix macOS CI for fpm-bootstrap executables built with gcc-9 #861
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awvwgk
approved these changes
Mar 30, 2023
arteevraina
approved these changes
Mar 30, 2023
|
Thank you all @henilp105 @awvwgk @arteevraina, I will merge this now so we can restore the CI. |
perazz
added a commit
to perazz/fpm-docs
that referenced
this pull request
Apr 11, 2023
perazz
added a commit
to fortran-lang/fpm-docs
that referenced
this pull request
Apr 12, 2023
* gfortran 9 tweak from [fpm#861](fortran-lang/fpm#861) * gcc variable fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The approach to statically link fpm on macOS seems far more complicated,
so I suggest we keep it simple for now, and create gcc-10 => dummy gcc-9 symbolic links to keep fpm-bootstrap executables 0.3.0 to 0.7.0 working on the new macOS images:
https://github.com/perazz/fpm/blob/5a74d581cbdfa8e86f183d35e54d707bf076b865/.github/workflows/CI.yml#L54-L64
This is tested working now.