Support for dependency path relative to the fpm.toml it’s written in #719
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. The dependency path is no longer relative to the top-level project, but relative to the fpm.toml path that contains it; 2. Update `new_dependency`, `new_dependencies` interface and usage, add `root` argument.
1. Add a dependency path example; 2. Update `new_dependency` test; 3. Update help manual.
1. Add hell_fpm_path to run_tests.sh; 2. Rm unused `file_not_found_error` reference; 3. Update `fpm_filesystem::dirname`.
awvwgk
approved these changes
Jul 22, 2022
|
@zoziha Sure, feel free to go ahead and merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To close #605 .
Description
The previous dependency
pathwas always quite the same as the top-level project, which made it difficult to make such anfpmpackage called by a higher-level project.Rust-cargoseems to take a more reasonable approach: dependency paths are relative to theCargo.tomlit’s written in.This PR attempts to support such improvements, which will allow us to publish
fpmpackages with component libraries.---- pkg-1 |---- fpm.toml |---- crate |---- pkg-2 |---- pkg-3 # pkg-1 fpm.toml [dependencies] pkg-2 = { path = 'crate/pkg-2' } # pkg-2 fpm.toml [dependencies] pkg-3 = { path = '../pkg-3' }What this PR does
dependency.f90::new_dependecyanddependency.f90::new_dependecies, adding therootoptional argument.join_path("", "fpm.toml"):