Skip to content

Add: critical section to mkdir in backend #613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 20, 2021
Merged

Add: critical section to mkdir in backend #613

merged 1 commit into from
Nov 20, 2021

Conversation

LKedward
Copy link
Member

Minor fix to get parallel builds working on Windows where mkdir fails if the directory already exists.

@LKedward
Add: critical section to mkdir in backend
197d643 
Allows parallel builds on Windows where mkdir complains if directory already exists.
@LKedward LKedward requested review from awvwgk and a user November 20, 2021 15:25
awvwgk
awvwgk approved these changes Nov 20, 2021
View reviewed changes
Copy link
Member

@awvwgk awvwgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, looks good to me.

@awvwgk awvwgk merged commit 9dc068d into fortran-lang:main Nov 20, 2021
@LKedward LKedward deleted the fix-windows-parallel-builds branch November 20, 2021 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awvwgk awvwgk awvwgk approved these changes

+1 more reviewer
Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LKedward @awvwgk