Skip to content

Conversation

ghost
Copy link

@ghost ghost commented Oct 6, 2021

This PR fixes #589

@ghost
Copy link
Author

ghost commented Oct 6, 2021

It seems that this special case also applies to LFortran on Windows with MSVC. This PR needs more work.

@ghost ghost marked this pull request as draft October 6, 2021 01:52
@LKedward
Copy link
Member

LKedward commented Oct 6, 2021

Thanks Carlos @brocolis! What's the naming convention for *.lib files? Do they always start with lib like on Linux or is it different?

@ghost
Copy link
Author

ghost commented Oct 6, 2021

What's the naming convention for *.lib files? Do they always start with lib like on Linux or is it different?

They don't always start with lib, it is different, it is usually name.lib, for example kernel32.lib, shell32.lib, etc.

@ghost ghost marked this pull request as ready for review October 13, 2021 11:09
@ghost
Copy link
Author

ghost commented Oct 13, 2021

It seems that this special case also applies to LFortran on Windows with MSVC. This PR needs more work.

This is a separate issue. It requires changes in LFortran.

@awvwgk
Copy link
Member

awvwgk commented Oct 13, 2021

It seems that this special case also applies to LFortran on Windows with MSVC. This PR needs more work.

This is a separate issue. It requires changes in LFortran.

Maybe LFortran's command line interface could attempt to do a normalization before passing anything through to MSVC's or GCC's linker. This way we don't have to pull any stunts in fpm to check whether the compiler wrapper is currently targeting MSVC or GCC. Not sure how pass-through arguments are currently handled in LFortran, in GCC we have -Wl, to pass arguments to the linker without affecting the compiler wrapper.

Copy link
Member

@awvwgk awvwgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one minor comment, otherwise looks good to me.

Co-authored-by: Sebastian Ehlert <28669218+awvwgk@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants