-
Notifications
You must be signed in to change notification settings - Fork 111
Change link command on Windows with ifort
or ifx
#590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
It seems that this special case also applies to LFortran on Windows with MSVC. This PR needs more work. |
Thanks Carlos @brocolis! What's the naming convention for |
They don't always start with |
This is a separate issue. It requires changes in LFortran. |
Maybe LFortran's command line interface could attempt to do a normalization before passing anything through to MSVC's or GCC's linker. This way we don't have to pull any stunts in fpm to check whether the compiler wrapper is currently targeting MSVC or GCC. Not sure how pass-through arguments are currently handled in LFortran, in GCC we have |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only one minor comment, otherwise looks good to me.
Co-authored-by: Sebastian Ehlert <28669218+awvwgk@users.noreply.github.com>
This PR fixes #589