Skip to content

Conversation

felixmosh
Copy link
Contributor

@felixmosh felixmosh commented Nov 8, 2022

Added React 18 as peer deps and tested it.

  • Title is human readable, as it will be included directly in CHANGELOG.md when we do a release
  • If this is a new user-facing feature, documentation has been added to API.md

@rkuykendall wdyt? should we trust ower tests? :]

@felixmosh felixmosh requested a review from rkuykendall November 8, 2022 20:25
@rkuykendall
Copy link
Member

@felixmosh I think so. If something fails, we can add a new test! I'd remove the build artifacts from this though as they are generated on release.

@felixmosh
Copy link
Contributor Author

Done :]

@felixmosh felixmosh merged commit 34ba66d into master Nov 8, 2022
@felixmosh felixmosh deleted the react-18-migration branch December 6, 2023 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants