Migrate to react testing lib instead of enzyme #679
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfe89d3 to
4977587
Compare
rkuykendall
reviewed
Jul 25, 2022
rkuykendall
reviewed
Jul 25, 2022
rkuykendall
approved these changes
Jul 25, 2022
|
Thank you for asking me to take a look, it was a pleasure to read. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
( what is the feature, or what is it this is PR fixing? )
CHANGELOG.mdwhen we do a releaseAPI.mddist/changes have not been committed.Tests run directly on the source code and all dist changes are computed and committed during Formsy release.
I've migrated all the tests to use react testing lib, in the process found some tests that were false, and testing implementation details.
This will allows as to review adding support for React 18 (enzyme doesn't supports it)