-
Notifications
You must be signed in to change notification settings - Fork 125
Automatic Library Updates #553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
b3237f1
to
46df770
Compare
664689e
to
cb399f0
Compare
Why is it not get merged? BTW, by the docs of tsdx, in order to gain lodash optimization, we need to install |
@felixmosh I usually just let Dependabot run on this branch, then merge this right before a release. Given our very recent large changes, I was gonna let this one sit a while. I was keeping lodash because you mentioned it was already in everyones trees. I tried to switch it to lodash-es here and saw NO change in filesize of any build files, which seems wrong? Do you want to try it? |
I was wrong regarding "loadsh is already in the consumer app tree", think of it, formsy-react releases a "concatanated" bundle which contains lodash code, therefore it won't help to consumer app. Anyway, it is better to stick to TSDX recommendation regarding installing |
784a8cf
to
415009f
Compare
8233914
to
6ddf572
Compare
771a61e
to
a6c336d
Compare
This reverts commit a6c336d.
This branch includes all automatic Dependabot library upgrades.
CHANGELOG.md
when we do a releaseAPI.md
dist/
changes have not been committed.Tests run directly on the source code and all dist changes are computed and committed during Formsy release.