Skip to content

Conversation

rkuykendall
Copy link
Member

This branch includes all automatic Dependabot library upgrades.

  • Title is human readable, as it will be included directly in CHANGELOG.md when we do a release
  • If this is a new user-facing feature, documentation has been added to API.md
  • Any dist/ changes have not been committed.

Tests run directly on the source code and all dist changes are computed and committed during Formsy release.

@felixmosh
Copy link
Contributor

Why is it not get merged?

BTW, by the docs of tsdx, in order to gain lodash optimization, we need to install lodash-es as well.

@rkuykendall
Copy link
Member Author

@felixmosh I usually just let Dependabot run on this branch, then merge this right before a release. Given our very recent large changes, I was gonna let this one sit a while.

I was keeping lodash because you mentioned it was already in everyones trees. I tried to switch it to lodash-es here and saw NO change in filesize of any build files, which seems wrong? Do you want to try it?

@felixmosh
Copy link
Contributor

I was wrong regarding "loadsh is already in the consumer app tree", think of it, formsy-react releases a "concatanated" bundle which contains lodash code, therefore it won't help to consumer app.

Anyway, it is better to stick to TSDX recommendation regarding installinglodash & lodash-es & let it to enable tree shake for the package itself. WDYT?

@rkuykendall rkuykendall merged commit 06a2f87 into master Jan 22, 2021
@rkuykendall rkuykendall deleted the frontend-bumps branch January 22, 2021 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants