fix: migrations with pg 13 #724

gfyrag · 2025-03-05T10:18:28Z

No description provided.

coderabbitai · 2025-03-05T10:18:43Z

Walkthrough

The SQL migration script in the file internal/storage/bucket/migrations/18-transactions-fill-inserted-at/up.sql has been updated. The original trigger creation command was replaced by a two-step process: first, an existing trigger is dropped if it exists; then, a new trigger is created. This trigger is set to activate after an update on the metadata column of the transactions table when the ledger matches the current ledger’s name.

Changes

File Path	Summary
`internal/storage/bucket/.../up.sql`	Modified trigger management: replaced `create or replace trigger` with a command to drop the trigger if it exists followed by creating a new trigger post-update.

Sequence Diagram(s)

sequenceDiagram
    autonumber
    participant MScript as "SQL Migration Script"
    participant Database as "Database"
    
    MScript->>Database: DROP TRIGGER IF EXISTS "update_transaction_metadata_history_<ledger_id>"
    MScript->>Database: CREATE TRIGGER "update_transaction_metadata_history_<ledger_id>" after UPDATE on metadata

sequenceDiagram
    autonumber
    participant App as "Application"
    participant TxTable as "Transactions Table"
    participant Trigger as "Trigger"
    
    App->>TxTable: Execute UPDATE on metadata column (ledger matches)
    TxTable->>Trigger: Condition check for metadata update
    Trigger->>TxTable: Execute trigger action (handle metadata history update)

Poem

Oh, I hopped through code so spry,
Dropped old triggers with a keen eye.
Replaced them fresh on metadata's call,
Ledger and updates standing tall.
A bunny’s joy in migration’s flight – all code feels just right!
🐇✨

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (2)

internal/storage/bucket/migrations/18-transactions-fill-inserted-at/up.sql (2)
15-16: Dynamic SQL for Dropping Triggers
The SQL statement used to drop the trigger is functionally correct. However, building dynamic SQL by simple concatenation may expose subtle issues if _ledger.id is not inherently text or if there are potential special characters. Consider using PostgreSQL’s format() function with the %I placeholder to safely interpolate identifiers. For example:
- _vsql = 'drop trigger if exists "update_transaction_metadata_history_' || _ledger.id || '" on "transactions"';
+ _vsql = format('drop trigger if exists %I on %I', 'update_transaction_metadata_history_' || _ledger.id, 'transactions');
This change improves safety and readability.

18-18: Dynamic SQL for Creating Triggers
The new dynamic SQL statement that creates the trigger is correct in its intent. However, similar to the drop statement, concatenating strings manually can lead to issues if _ledger.name contains single quotes or other special characters. Consider using format() with %I for identifiers and %L for literals, which would handle quoting for you. For example:
- _vsql = 'create trigger "update_transaction_metadata_history_' || _ledger.id || 
- '" after update of metadata on "transactions" for each row when (new.ledger = ''' 
- || _ledger.name || ''') execute procedure update_transaction_metadata_history()';
+ _vsql = format(
+   'create trigger %I after update of metadata on %I for each row when (new.ledger = %L) execute procedure update_transaction_metadata_history()',
+   'update_transaction_metadata_history_' || _ledger.id,
+   'transactions',
+   _ledger.name
+ );
This refactoring will help prevent SQL injection vulnerabilities and potential runtime errors due to unescaped characters.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 07da5a4 and c3dfee7.

⛔ Files ignored due to path filters (4)

go.mod is excluded by !**/*.mod
go.sum is excluded by !**/*.sum, !**/*.sum
tools/generator/go.mod is excluded by !**/*.mod
tools/generator/go.sum is excluded by !**/*.sum, !**/*.sum

📒 Files selected for processing (1)

internal/storage/bucket/migrations/18-transactions-fill-inserted-at/up.sql (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (1)

GitHub Check: Tests

codecov · 2025-03-05T10:21:19Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.89%. Comparing base (07da5a4) to head (c3dfee7).
Report is 2 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #724   +/-   ##
=======================================
  Coverage   81.89%   81.89%           
=======================================
  Files         135      135           
  Lines        7291     7291           
=======================================
  Hits         5971     5971           
  Misses       1012     1012           
  Partials      308      308

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

fix: migrations with pg 13

c3dfee7

gfyrag requested a review from a team as a code owner March 5, 2025 10:18

coderabbitai bot reviewed Mar 5, 2025

View reviewed changes

gfyrag enabled auto-merge March 5, 2025 11:09

flemzord approved these changes Mar 5, 2025

View reviewed changes

gfyrag added this pull request to the merge queue Mar 5, 2025

Merged via the queue into main with commit 63b96d8 Mar 5, 2025
10 checks passed

gfyrag deleted the feat/pg13-compat branch March 5, 2025 11:23

coderabbitai bot mentioned this pull request Mar 5, 2025

feat: refine pulumi #721

Merged

gfyrag mentioned this pull request Mar 14, 2025

fix: prevent deadlocks #770

Merged

coderabbitai bot mentioned this pull request Apr 28, 2025

fix: missing denormalized data in logs #882

Merged

coderabbitai bot mentioned this pull request May 22, 2025

fix: set not null on some columns #930

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: migrations with pg 13 #724

fix: migrations with pg 13 #724

Uh oh!

gfyrag commented Mar 5, 2025

Uh oh!

coderabbitai bot commented Mar 5, 2025 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Uh oh!

codecov bot commented Mar 5, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

fix: migrations with pg 13 #724

fix: migrations with pg 13 #724

Uh oh!

Conversation

gfyrag commented Mar 5, 2025

Uh oh!

coderabbitai bot commented Mar 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Mar 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

coderabbitai bot commented Mar 5, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

codecov bot commented Mar 5, 2025 •

edited

Loading