Skip to content

Conversation

csasarak
Copy link
Contributor

@csasarak csasarak commented Aug 22, 2025

Overview

Right now we output a spurious message about reachability not being enabled for an org if it isn't. This PR removes it.

Acceptance criteria

Before:
Screenshot From 2025-08-22 14-16-32

After:
Screenshot From 2025-08-22 14-16-45

Testing plan

I manually tested by disabling reachability in my org, then runninig cabal run fossa -- analyze <project> and also fossa analyze <project>.

Risks

None

Metrics

Is this change something that can or should be tracked? If so, can we do it today? And how? If its easy, do it

References

conversation

Checklist

  • I added tests for this PR's change (or explained in the PR description why tests don't make sense).
  • If this PR introduced a user-visible change, I added documentation into docs/.
  • If this PR added docs, I added links as appropriate to the user manual's ToC in docs/README.ms and gave consideration to how discoverable or not my documentation is.
  • If this change is externally visible, I updated Changelog.md. If this PR did not mark a release, I added my changes into an ## Unreleased section at the top.
  • If I made changes to .fossa.yml or fossa-deps.{json.yml}, I updated docs/references/files/*.schema.json AND I have updated example files used by fossa init command. You may also need to update these if you have added/removed new dependency type (e.g. pip) or analysis target type (e.g. poetry).
  • If I made changes to a subcommand's options, I updated docs/references/subcommands/<subcommand>.md.

@csasarak csasarak marked this pull request as ready for review August 22, 2025 19:19
@csasarak csasarak requested a review from a team as a code owner August 22, 2025 19:19
@csasarak csasarak requested a review from spatten August 22, 2025 19:19
Copy link
Contributor

@spatten spatten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Nice change!

@csasarak csasarak enabled auto-merge (squash) August 22, 2025 19:26
@csasarak csasarak merged commit 90c150b into master Aug 22, 2025
19 of 20 checks passed
@csasarak csasarak deleted the delete-reachability-notice branch August 22, 2025 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants