Skip to content

Conversation

james-fossa
Copy link
Contributor

Overview

Masks a logged API secret a la: --secret ******. I did not add tests for this because it is purely a logging concern visible locally on run.

Acceptance criteria

Does not print any secrets in debug logging.

Testing plan

Ran locally with make install-local, analyze --x-snippet-scan --debug on a local repo

Risks

N/A

Metrics

N/A

References

N/A

Checklist

  • I added tests for this PR's change (or explained in the PR description why tests don't make sense).
  • If this PR introduced a user-visible change, I added documentation into docs/.
  • If this PR added docs, I added links as appropriate to the user manual's ToC in docs/README.ms and gave consideration to how discoverable or not my documentation is.
  • If this change is externally visible, I updated Changelog.md. If this PR did not mark a release, I added my changes into an ## Unreleased section at the top.
  • If I made changes to .fossa.yml or fossa-deps.{json.yml}, I updated docs/references/files/*.schema.json AND I have updated example files used by fossa init command. You may also need to update these if you have added/removed new dependency type (e.g. pip) or analysis target type (e.g. poetry).
  • If I made changes to a subcommand's options, I updated docs/references/subcommands/<subcommand>.md.

@james-fossa james-fossa requested a review from a team as a code owner August 20, 2025 19:57
@james-fossa james-fossa requested review from nficca and spatten August 20, 2025 19:57
@james-fossa james-fossa force-pushed the quickfix-leaked-secret branch from 4d6dbc3 to d261158 Compare August 20, 2025 20:14
Copy link
Contributor

@spatten spatten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix!

@james-fossa james-fossa merged commit 442e872 into master Aug 20, 2025
19 checks passed
@james-fossa james-fossa deleted the quickfix-leaked-secret branch August 20, 2025 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants