Skip to content

Conversation

nficca
Copy link
Contributor

@nficca nficca commented Aug 6, 2025

I noticed we have a nix shell environment and thought I'd test it out. Ran into some errors on my Mac and had to make some minor tweaks to get it working.

@nficca nficca marked this pull request as ready for review August 6, 2025 16:00
@nficca nficca requested a review from a team as a code owner August 6, 2025 16:00
@nficca nficca requested a review from csasarak August 6, 2025 16:00
Copy link
Contributor

@csasarak csasarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM.

I'm interested in what you're using it for. I don't think I've ever really used this. I thought it mainly supports our integration tests.

@nficca
Copy link
Contributor Author

nficca commented Aug 6, 2025

I'm interested in what you're using it for. I don't think I've ever really used this. I thought it mainly supports our integration tests.

I wanted to see if I could avoid manually installing all the tools on my system and just shell into a virtual environment with everything ready to go. Just did nix-shell --command $SHELL and (after I made the small fixes here) it worked. Was able to build, test, lint, etc.

@nficca nficca merged commit 51add54 into master Aug 6, 2025
19 checks passed
@nficca nficca deleted the update-nix-shell branch August 6, 2025 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants