Do not use F3 for database handling #1296
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
688d1ef to
166281e
Compare
584cc26 to
2349567
Compare
Closed
Most PDO wrappers only support a single query per exec call. Let’s use that style along with explicit transactions instead of fatfree’s arrays of queries wrapped in transaction to make the upcoming migration easier.
F3 is radioactive. Let’s take the \DB\SQL class and remove F3 references. #1266
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
all items are shown as unread and unstarred –cannot reproduceDatabaseConnectionerror?