Skip to content

Conversation

jtojnar
Copy link
Member

@jtojnar jtojnar commented Sep 16, 2019

Closes: #1127, #1132, #1028

This makes selfoss much more navigable using keyboard.

In the future we can disable it in :focus and only apply it in :focus-visible.
It slightly simplifies the code, allows styling expanded items and serves as a step forward in our accessibility.
@jtojnar jtojnar added this to the 2.19 milestone Sep 16, 2019
@jtojnar jtojnar requested a review from niol September 16, 2019 19:39
@jtojnar
Copy link
Member Author

jtojnar commented Sep 16, 2019

@niol could you please check, especially the last commit?

@akash07k
Copy link

Thanks @jtojnar For this.
Please check my other comments on previous issues.
If possible, can we implement pagination for the best user experience and use aria-current on the current page?
This link represents very nice explanations and examples to this:
https://www.a11ymatters.com/pattern/pagination/

@jtojnar jtojnar merged commit 0091b26 into master Sep 23, 2019
@jtojnar jtojnar deleted the a11y-fixes branch September 23, 2019 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Horizontal scrolling instead of single column view
3 participants