Skip to content

Support setting SplineChar width from importOutlines. #5004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Support setting SplineChar width from importOutlines. #5004

wants to merge 2 commits into from

Conversation

frank-trampe
Copy link
Contributor

This set of changes allows setting SplineChar width from an imported discrete SVG file by setting the new "dimensions" flag in the Python routine SplineChar.importOutlines. Default behavior remains ignoring the SVG dimensions.

Test as follows.

frank@Luther-1:~/Projects_1/2022/Weather_Typeface_1/Samples_1$ /var/tmp/ff10/fontforge/build/bin/fontforge -lang=py -script
Copyright (c) 2000-2019. See AUTHORS for Contributors.
 License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
 with many parts BSD <http://fontforge.org/license.html>. Please read LICENSE.
 Version: 20220308
 Based on sources from 17:58 UTC 23-Jul-2019-ML-D-GDK3.
 Based on source from git with hash: 4f83172d44db72544b1bacf11b79bddf1d236647
PythonUI_Init()
copyUIMethodsToBaseTable()
Program root: /var/tmp/ff10/fontforge/build
Python 3.7.5 (default, Dec  9 2021, 17:04:37)
[GCC 8.4.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> font0 = fontforge.font()
>>> font0.ascent = 55
>>> font0.descent = 0
>>> char0 = font0.createChar(257)
>>> char0.importOutlines(filename="WeatherSymbol_WMO_CloudHigh_CH_1.svg",scale=False)
<fontforge.glyph at 0x0x7f27eb78e4b0 U+0101 "glyph0">
>>> font0.save("font0_5.sfd")
<fontforge.font at 0x0x7f27eb78e430 "Untitled1">
>>> quit()

WeatherSymbol_WMO_CloudHigh_CH_1

@frank-trampe
Add support for a "dimensions" flag in SplineChar.importOutlines in t…
feadbda 
…he Python bindings that sets the width of the glyph from an imported SVG.
@frank-trampe frank-trampe requested a review from skef May 5, 2022 14:40
@frank-trampe
Copy link
Contributor Author

Oh, wait! I accidentally rolled in some unfinished spline overlap fixes.

@frank-trampe frank-trampe mentioned this pull request May 5, 2022
Merged
@frank-trampe
Copy link
Contributor Author

See #5005.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skef skef Awaiting requested review from skef

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@frank-trampe