-
Notifications
You must be signed in to change notification settings - Fork 741
fsys: resolve symlinks on Unix platforms #4626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems fine to me. Anyone else have concerns?
Can you explain a full example? imo if you want to resolve symlinks this should be done on the path to the fontforge binary itself instead of the folder containing fontforge (like there is a potential difference resolving |
This could happen in many Linux distro where Regarding your concern with the path resolution, I will change my patch to resolve the path to the binary. |
Which distro is this? Sounds more like a problem that if you symlink /bin to /usr/bin, then so too should /share to /usr/share |
if ( (buf = realpath(program_dir, NULL)) ) { | ||
free(program_dir); | ||
program_dir = buf; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The whitespace is misaligned.
This will make
fontforge
resolve the symbolic links on the Unix platforms when loading its assets.This resolves the issue where if
fontforge
is invoked through symlink, it will not be able to load the resources.Type of change
This change is