Fix crash on exit introduced in previous commit #4100
Conversation
When the number of layers is greater than 2, as in Chomsky.sfd and most of my other fonts, FontForge will crash on exiting. This is just a simple mistake @skef made.
|
@frank-trampe You seem to have taken away my ability to merge a PR without a review. I'd like to ask you to restore it. This bug has the potential to also corrupt people's files. CI has passed and I'd like to merge this ASAP. I of course will not abuse the privilege to merge without a review, I never had done so in the past. I merged #3798 without review. This is another case where delay is unnecessary. |
|
@ctrlcctrlv Anyone grabbing source revisions between releases should be prepared for somewhat more instability. A day or two here and there on merging should be OK, especially relative to merging unreviewed code. And as long as I'm being explicitly picked out in the issue and the commit message I'll note here that you were the reviewer on #4091 and had an opportunity to catch this one. |
|
Indeed @skef, that's very true :-) For posterity this is just as much my fault as yours |
When the number of layers is greater than 2, as in Chomsky.sfd and most of my other fonts, FontForge will crash on exiting.
This is just a simple mistake @skef made. I'd say merging this fix is quite urgent. This closes #4099.
Type of change