Improve {v,h}mtx error when not enough data to decompile sidebearings #3901
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ncated Address #3843 previously we were only raising if table size was smaller than expected (numGlyphs * numberOfLongMetrics); now we also include the sidebearings to compute the expected minimum table size and raise the same error when the table appears to be truncated (i.e. not enough data to decompile sidebearings)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3843
Sometimes hmtx or vmtx may appear truncated with not enough data to decompile the list of sidebearings at the end of the table. Currently an IndexError would be thrown which is confusing.
This PR makes it so we raise the same TTLibError(f"not enough {tableTag} data") that we already raise when we don't have enough table data to decompile the "long" metrics.