Skip to content

Copy name IDs in use before scrapping or scrambling them for webfonts #3853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jun 6, 2025
Merged

Copy name IDs in use before scrapping or scrambling them for webfonts #3853

merged 8 commits into from
Jun 6, 2025

Conversation

madig
Copy link
Collaborator

@madig madig commented Jun 2, 2025 •
edited
Loading

Preserve select nameIDs in fvar and STAT when obfuscating names, to avoid dangling name IDs in subset fonts.

Closes #3773.

@madig
Copy link
Collaborator Author

madig commented Jun 4, 2025

Hm, how to get CPAL labels and the feat table into a test font?

@anthrotype
Copy link
Member

colorLib.buildCPAL can build palette labels, there's a bunch of tests in Tests/colorLib/builder_test.py, e.g.

fonttools/Tests/colorLib/builder_test.py

Line 151 in e857fe5

def test_build_CPAL_v1_labels():

as to feat, it's defined in otData.py and it doesn't look like we test it anywhere..

@madig
Copy link
Collaborator Author

madig commented Jun 5, 2025

I limited the test to STAT, fvar, ss and cv feature names and CPAL labels for now.

@madig madig marked this pull request as ready for review June 5, 2025 10:49
@madig madig force-pushed the better-handle-name-id-deletion branch from 04a70d4 to 1280acb Compare June 5, 2025 10:53
anthrotype
anthrotype reviewed Jun 5, 2025
View reviewed changes
@madig madig force-pushed the better-handle-name-id-deletion branch from 3267eb8 to d563e04 Compare June 5, 2025 13:47
anthrotype
anthrotype reviewed Jun 5, 2025
View reviewed changes
anthrotype
anthrotype reviewed Jun 5, 2025
View reviewed changes
anthrotype
anthrotype reviewed Jun 5, 2025
View reviewed changes
anthrotype
anthrotype reviewed Jun 5, 2025
View reviewed changes
@anthrotype anthrotype force-pushed the better-handle-name-id-deletion branch from 9e61e2a to 75676f5 Compare June 6, 2025 09:26
@anthrotype anthrotype merged commit 8cd664d into main Jun 6, 2025
11 checks passed
@anthrotype anthrotype deleted the better-handle-name-id-deletion branch June 6, 2025 09:40
This was referenced Jun 13, 2025
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anthrotype anthrotype anthrotype left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[subset] --obfuscate-names can drop or scramble names used outside of the name table
2 participants
@madig @anthrotype