fix iterable check for Python 3.13.4 and newer #3855
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the `feaLib/ast.py` snippet used to check whether a type is iterable to work correctly with Python 3.13.4. The snippet wrongly assumed that a generator expression will raise immediately when the RHS of `in` is not iterable. This is no longer the case with Python 3.13.4, and such a generator only raises when you actually start iterating. Use a plain `for` expression to start iterating and catch the problem more reliably. Fixes fonttools#3854
|
While this is a bug with Python 3.13.4, I'm inclined to accept this fix. |
|
Hmm, good point, I've assumed the type will involve only containers and not iterators. I don't know how reliable |
|
The exact equivalent to the original generator expression is |
Switch to using `iter(lookup)` as suggested by @dscorbett as the exact equivalent of the original expression. Most importantly, this avoids incidentally taking the first item off `lookup` if it is an iterator.
|
Updated to use |
|
Can this be merged? I'm seeing bot fails due to this I believe: |
|
Thank you! |
|
Thank you. Somehow I missed this. I also just tagged a new release, should get published soon once the CI completes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the
feaLib/ast.pysnippet used to check whether a type is iterable to work correctly with Python 3.13.4. The snippet wrongly assumed that a generator expression will raise immediately when the RHS ofinis not iterable. This is no longer the case with Python 3.13.4, and such a generator only raises when you actually start iterating. Use a plainforexpression to start iterating and catch the problem more reliably.Fixes #3854