[feaLib] Improve single substitution promotion #3849
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Feel free to bikeshed over the names of the new classes and methods, I don’t particularly like them and couldn’t come with anything better. |
|
@khaledhosny can you rebase or fix the merge conflicts? thanks |
anthrotype
approved these changes
May 28, 2025
Move the logic down into the builder so that it is applied after lookups are split due to e.g. different lookup flags or interspersed contextual substitution rules. Arguably the builder was the right place for this all along, but I took the either route (twice!) before. Fixes #3846
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the logic down into the builder so that it is applied after lookups are split due to e.g. different lookup flags or interspersed contextual substitution rules. Arguably the builder was the right place for this all along, but I took the either route (twice!) before.
Fixes #3846