[feaLib] Add promoted single substitutions to aalt feature #3847
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a single substitution was promoted to a multiple or ligature substitutions, we would no longer add it to aalt feature (when requested) since only single and alternate substations are added there. This can be considered a regression from lookup promotion. Since a single-looking substitution wouldn’t occurs in ligature or multiple substitution unless we promoted it, it should be safe to add these to allt feature. Fixes #3845
cmyr
approved these changes
May 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a single substitution was promoted to a multiple or ligature substitutions, we would no longer add it to aalt feature (when requested) since only single and alternate substations are added there.
This can be considered a regression from lookup promotion. Since a single-looking substitution wouldn’t occurs in ligature or multiple substitution unless we promoted it, it should be safe to add these to allt feature.
Fixes #3845