[merge] handle cmap format=14 subtable #3830
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f2c41f2 to
71de136
Compare
anthrotype
reviewed
May 19, 2025
anthrotype
reviewed
May 19, 2025
Comment on lines
218
to
219
| mapId = id(table.uvsDict if table.isUVS() else table.cmap) | ||
| offset = seen.get(mapId) |
There was a problem hiding this comment.
why this change? The PR title and description only mention the merge tool but this seems to be changing the cmap table compile method itself.
There was a problem hiding this comment.
Good question. Previously I thought cmap was not defined in the format=14 subtable, it turns out we have defined a dummy cmap property being an empty dictionary.
fonttools/Lib/fontTools/fontBuilder.py
Line 433 in f9c3b63
I will revise the merger logic and hopefully we don't have to change the cmap compile method.
anthrotype
approved these changes
May 19, 2025
This reverts commit 71de136. # Conflicts: # Lib/fontTools/ttLib/tables/_c_m_a_p.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we add cmap format=14 table support to the merge tool.
For duplicate UVS mapping entries, the tool prefer the previous font, aligned with how we deal with cmap duplicates.