fix(core): set init_done before sourcing after directories #2027
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is stale because it has been open 30 days with no activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a timing issue where a plugin loaded during the after directory scan would have its own after directory skipped.
Description
This moves the init_done variable before the after directory is sourced. This fixes an issue when a plugin is sourced while the runtime path list is being looped to find all after directories. If init_done is not set, the code assumes that its own after directory will be sourced in this loop, however since it already started this is impossible.
Example Scenario
This fixes an error for me when cmp_luasnip loads, which in its after/plugin directory it calls
require("cmp"). This causes nvim-cmp and all of its dependencies to load, however none of these after directories would get sourced.