feat: generic type support for attachable #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The attachable implementation uses String as key type. If someone selects the same string in the top layer, the value will be shaded in the lower layer. Although we can isolate using the namespace of a string, it is not an absolute security guarantee. Adding generics does not impose a burden on using a string as the key type, but it should be noted that the current default implementation uses a hash map for storage, which requires the key to meet the requirements of the hash map for the key type. Resolves: #4
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #5 +/- ##
===========================================
Coverage 100.00% 100.00%
Complexity 11 11
===========================================
Files 2 2
Lines 14 14
Branches 3 3
===========================================
Hits 14 14
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The attachable implementation uses String as key type. If someone selects the same string in the top layer, the value will be shaded in the lower layer.
Although we can isolate using the namespace of a string, it is not an absolute security guarantee. Adding generics does not impose a burden on using a string as the key type, but it should be noted that the current default implementation uses a hash map for storage, which requires the key to meet the requirements of the hash map for the key type.
Resolves: #4