Skip to content

keymap combinations assume QWERTY (macOS) #29

@thisma

Description

@thisma
  • OS: macOS 12
  • Focus Version: 0.1.6

Describe the bug
On macOS the keymap combinations assume US QWERTY is the keyboard layout.

Example 1
To Reproduce with AZERTY layout
Steps to reproduce the behavior:

  1. Go to 'System Preferences -> Keyboard -> Input Sources'
  2. Click on '+'
  3. In the search field type 'French'
  4. Click ABC - AZERTY
  5. Click Add
  6. Click ABC - AZERTY
  7. Open Focus
  8. Press Command-N (note the 'N' key is in the same place on both the AZERTY and QWERTY layouts)
  9. Type "testing"
  10. Press Command-Z (note the 'Z' key on the AZERTY layout is in the location of the 'W' key on the QWERTY layout, and vice-versa)

Expected behavior
The typing of the word 'testing' to be undone.

Actuall behaviour
The file is closed

Example 2
To Reproduce with Dvorak layout
Steps to reproduce the behavior:

  1. With a US keyboard layout
  2. Open Focus
  3. Press Command-Shift-P
  4. Type 'Open Global Config'
  5. Press 'Return'
  6. Move the cursor to the beginning of the 'allow file extensions' list (which begins with ".jai .c .cpp"
  7. Type ".plist "
  8. Go to 'System Preferences -> Keyboard -> Input Sources'
  9. Click on '+'
  10. In the search field type 'dvorak'
  11. Click Dvorak
  12. Click Add
  13. Click Dvorak
  14. Go back to Focus
  15. Press Command-Z (note the 'Z' key on the Dvorak layout is in the location of the '/' key looking at a QWERTY layout)

Expected behavior
The typing of the word ".plist " to be undone.

Actuall behaviour
The 'Toggle Code Comment' command is issued, adding a "# " to the beginning of the line.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Input-module-issueThe dang Input moduleMacSomething specific to macOS

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions