Skip to content

Conversation

fmalmeida
Copy link
Owner

@fmalmeida fmalmeida commented Nov 10, 2022

fmalmeida and others added 30 commits August 29, 2022 23:09
* first bakta addition test

* Fixing error when phigaro output was empty (#55) (#56)

* adding checkIfExists rules to input loading

* Update build.sh

* fixed report if else statement

* updated version and changelog

* fix example samplesheet url

* Create nf-core-bacannot-compare_logo_dark.png

* Update phigaro.nf

* Update CHANGELOG.md

* Update CHANGELOG.md

* Update .gitignore

* Update bacannot.nf

* workflow runs from top to bottom

* workflow correctly working

* changing version manifest

* explaining how to use bakta

* adding variables to generic annotation

* adding victors backup db

* report_general understands bakta

* report_resistance understands bakta

* update hmmer to working version with PGAP

* update hmmer to working version with PGAP (#59)

* update hmmer to working version with PGAP (#59) (#60)

* Update resfinder2gff.py

* Update addBedtoolsIntersect.R

* Update addBedtoolsIntersect.R

* Update addBedtoolsIntersect.R

* Update addBedtoolsIntersect.R

* Update docker.config

* download db if not available

* Update merge_annotations.nf

* Update merge_annotations.nf

* update process label

* Update merge_annotations.nf

* fix docker file ownerships

* added retry label for bakta
* Add step making Blast DB when annotating custom db

Blast database throw error for no alias or index file found for
nucleotide database, when using blastn. Thus, make blast database
before execute blastn to custom database on genome.

* Remove space when generate link in Shiny markdown

Whitespace occurs when generated links for custom database report in
Shiny markdown. Specify seperate string to emtpy string to fix this.

* fix: script was calling an out of bounds value

* handle exceptions and missing values

* increment test profile

* also build for proteins

* Use correct version of customdb_gffs in REPORTS module

Co-authored-by: fmalmeida <felipemarques89@gmail.com>
@fmalmeida
Copy link
Owner Author

Note:

This PR may delay a little bit more because more work is still required in the CIRCOS modules in order to have better defaults to have good enough plots that users can further customise later.

@fmalmeida fmalmeida added the stalled Implementation is slow or difficult label Dec 6, 2022
@fmalmeida
Copy link
Owner Author

fmalmeida commented Dec 12, 2022

Hi @lam-c
I tried today the pipeline with the new version of scripts, docker images and all, and that problem with custom annotations in the server is solved.

I am just wanting to finalize the pending work in the circos sub-workflow before merging. I hope I can get it merged this week.

@fmalmeida fmalmeida added bug Something isn't working enhancement New feature or request fixed and removed stalled Implementation is slow or difficult labels Dec 12, 2022
@fmalmeida
Copy link
Owner Author

Last three steps for release: #70 (comment)

@fmalmeida fmalmeida marked this pull request as ready for review December 19, 2022 18:10
@fmalmeida fmalmeida merged commit aa871de into master Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request fixed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

module for generating circos plot for contigs Custom database report file bugs
2 participants