Skip to content

Implement regex exclusions for alerts #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 8, 2021
Merged

Implement regex exclusions for alerts #138

merged 1 commit into from
Feb 8, 2021

Conversation

stefanprodan
Copy link
Member

@stefanprodan stefanprodan commented Feb 8, 2021 •
edited
Loading

This PR adds a option field called exclusionList to the Alert API.

Fix: #137

Example usage

Skip alerting if the message matches a golang regex from the exclusion list:

apiVersion: notification.toolkit.fluxcd.io/v1beta1
kind: Alert
metadata:
  name: flux-system
  namespace: flux-system
spec:
  providerRef: 
    name: on-call-slack
  eventSeverity: error
  eventSources:
    - kind: GitRepository
      name: flux-system
  exclusionList:
    - "waiting.*socket"

The above definition will not send alerts for transient Git clone errors like:

unable to clone 'ssh://git@ssh.dev.azure.com/v3/...', error: SSH could not read data: Error waiting on socket

@stefanprodan stefanprodan added enhancement New feature or request area/alerting Alerting related issues and PRs labels Feb 8, 2021
@stefanprodan stefanprodan requested a review from hiddeco February 8, 2021 12:30
@stefanprodan stefanprodan mentioned this pull request Feb 8, 2021
Closed
hiddeco
hiddeco reviewed Feb 8, 2021
View reviewed changes
@stefanprodan
Implement regex exclusions for alerts
5c9e95c 
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
@stefanprodan stefanprodan merged commit 8ccdc94 into main Feb 8, 2021
@stefanprodan stefanprodan deleted the alert-exclusionList branch February 8, 2021 15:49
@stefanprodan stefanprodan mentioned this pull request Feb 10, 2021
Closed
29 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hiddeco hiddeco hiddeco approved these changes

Assignees
No one assigned
Labels
area/alerting Alerting related issues and PRs enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Exclude messages from alerting
2 participants
@stefanprodan @hiddeco