This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[webview_flutter_android] Updates the Dart InstanceManager to take a listener for when an object is garbage collected #6148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bparrishMines
commented
Jul 27, 2022
| @@ -23,51 +23,179 @@ mixin Copyable { | |||
| Copyable copy(); | |||
There was a problem hiding this comment.
bparrishMines
commented
Jul 27, 2022
| @@ -7,29 +7,137 @@ import 'package:webview_flutter_android/src/instance_manager.dart'; | |||
|
|
|||
There was a problem hiding this comment.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 3, 2022
…to take a listener for when an object is garbage collected (flutter/plugins#6148)
yutaaraki-toydium
pushed a commit
to yutaaraki-toydium/plugins
that referenced
this pull request
Aug 12, 2022
…listener for when an object is garbage collected (flutter#6148)
mauricioluz
pushed a commit
to mauricioluz/plugins
that referenced
this pull request
Jan 26, 2023
…listener for when an object is garbage collected (flutter#6148)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copies over the
InstanceManagerfromwebview_flutter_wkwebviewand updates method names.Part of flutter/flutter#107199.
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.