This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[in_app_purchase] Bump dependencies on json_serializable, build_runner #4386
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Regenerate output Also put in a pointer to the json_serializable issue related to creating stand-alone enum converters
|
LGTM, we need to do a patch version bump, and add a new entry to the CHANGELOG. |
|
@cyanglaz – there is zero runtime affect here, though. Do you always release every tweaks to the code? |
|
@kevmoo we usually release what makes sense. If it is ok to not release this version, you can add a NEXT entry in the CHANGELOG, so it will be included in the next release. See https://github.com/flutter/plugins/blob/af2896b199ecc3cc5e1ed3000b009f65fc05c9cd/packages/wifi_info_flutter/wifi_info_flutter/CHANGELOG.md#next |
|
@cyanglaz – PTAL |
cyanglaz
reviewed
Sep 27, 2021
Co-authored-by: Chris Yang <ychris@google.com>
|
@cyanglaz – PTAL |
|
Ooops! Just saw the label, @cyanglaz – did I break something? |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 27, 2021
|
It should be fine, the label is just for auto-merge :) You can still do it manually after ensuring the ci passes. |
fluttergithubbot
pushed a commit
to flutter/flutter
that referenced
this pull request
Sep 27, 2021
NickalasB
added a commit
to NickalasB/plugins
that referenced
this pull request
Sep 27, 2021
* master: Load navigation controls immediately. (flutter#4378) [ci] Temporary run publish task on Flutter stable channel. (flutter#4388) [in_app_purchase] Bump dependencies on json_serializable, build_runner (flutter#4386) # Conflicts: # packages/webview_flutter/webview_flutter_wkwebview/CHANGELOG.md
clocksmith
pushed a commit
to clocksmith/flutter
that referenced
this pull request
Oct 29, 2021
amantoux
pushed a commit
to amantoux/plugins
that referenced
this pull request
Dec 11, 2021
flutter#4386) Regenerate output Also put in a pointer to the json_serializable issue related to creating stand-alone enum converters Co-authored-by: Chris Yang <ychris@google.com>
KyleFin
pushed a commit
to KyleFin/plugins
that referenced
this pull request
Dec 21, 2021
flutter#4386) Regenerate output Also put in a pointer to the json_serializable issue related to creating stand-alone enum converters Co-authored-by: Chris Yang <ychris@google.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regenerate output
Also put in a pointer to the json_serializable issue related to creating
stand-alone enum converters