[google_sign_in] Adds "Button" Sign In for Web. #3461

ditman · 2023-03-15T04:48:19Z

This PR modifies the Google Sign In plugin so Web application authors can render a "Google Sign In Button" (like this one).

This is needed to obtain a guaranteed idToken from the user that is signing in, since the previous method, signInSilently might be aborted by the user, and the programmatic signIn wouldn't be able to provide that token.

This PR also updates the example apps so they work with the new web API (a combo of renderButton + canAccessScopes + requestScopes), and the mobile API (signIn + requestScopes).

(This is just a RFC PR, since each package needs to be landed separately)

Issues

Blocked by: [gis_web] Improves renderButton API exports. #3432
Fixes [google_sign_in_web] Display Sign In With Google button flutter#121781
Blocks Build dashboard sign in silently is failing flutter#121275
The lack of idToken was mentioned by many users in the original issue.

Testing

Added tests to core plugin and platform_interface packages.
Web package needs tests, especially of the "flexible html element view" widget.
Deployed google_sign_in example:
- https://dit-gis-test.web.app
Deployed google_sign_in_web "button_tester" example:
- https://dit-gis-button-test.web.app

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

ditman · 2023-03-15T05:29:26Z

�[31mThe following packages had errors:�[0m
�[31m  google_sign_in/google_sign_in:
    google_sign_in/google_sign_in/example (Android)�[0m
�[31mSee above for full details.�[0m

It's very nice that the CI is catching that I'm breaking the Android compilation. I'll probably need to hide the renderButton call behind a conditional import!

c-seeger

First look login works! Great job so far! 👍

The JavaScript API itself seems very restrictive in it's design options. If possible maybe you can hint me a way to open an issue for them to see if we can get some of the restrictions out of the way.

For now the introduction of the new button comes with heavy design breakers, which I guess our app is not the only "login tower" that will suffer from these restrictions.

packages/google_sign_in/google_sign_in_web/lib/src/button_configuration.dart

packages/google_sign_in/google_sign_in_web/example/lib/button_tester.dart

packages/google_sign_in/google_sign_in/example/lib/main.dart

ditman · 2023-03-16T04:04:48Z

(Android seems to be happy again)

ditman · 2023-03-21T01:44:58Z

Making PR "ready for review" after pushing some extra tests.

SeriousMonk · 2023-03-26T10:43:53Z

With the deadline for migration to GIS coming up in 5 days, this pull request is fundamental to keep a working google sign in flow.
Are we going to have this merged before the 31st? I am more than happy to help if any help is needed to speed up this process.

stuartmorgan-g

I left some questions/comments. Mostly I just want to make sure we understand how these changes will work on mobile.

Someone other than me will need to review the actual web parts.

packages/google_sign_in/google_sign_in/lib/google_sign_in.dart

packages/google_sign_in/google_sign_in/example/lib/main.dart

packages/google_sign_in/google_sign_in/CHANGELOG.md

stuartmorgan-g · 2023-03-27T19:56:11Z

.../google_sign_in/google_sign_in_platform_interface/lib/google_sign_in_platform_interface.dart

+  /// These will normally come from asynchronous flows, like the Google Sign-In
+  /// Button Widget from the Web implementation, and will be funneled directly
+  /// to the `onCurrentUserChanged` Stream of the plugin.
+  Stream<GoogleSignInUserData?>? get userDataEvents => null;


What are the implications of not implementing this? E.g., are we going to have issues on mobile until we do?

We probably need more comments on this method for implementors.

The Core plugin optionally grabs this stream (if not null), and connects it to a similar stream it owns.

The problem that this is solving is that plugins cannot inject (de)authentication events from their implementations, currently those events can only come from programmatically interacting with (some) methods of the core plugin.

Mobile should not be affected by not having these, but IMO the API of the plugin would be much better if signIn/signInSilently/signOut and friends returned a Future, and the results of those calls were funneled through this stream (or something similar), to make authentication (and maybe authorization) events fully asynchronous. (but this is "future of the google sign-in plugin" terrain)

stuartmorgan-g · 2023-03-27T19:58:21Z

packages/google_sign_in/google_sign_in/lib/google_sign_in.dart

+  /// Checks if the given `accessToken` authorized to access all `scopes`.
+  Future<bool> canAccessScopes(String? accessToken, List<String> scopes) async {
+    await _ensureInitialized();
+    return GoogleSignInPlatform.instance.canAccessScopes(accessToken, scopes);


Do the mobile SDKs give us the ability to implement this method everywhere?

I think so, here's the Android version:

https://developers.google.com/android/reference/com/google/android/gms/auth/api/signin/GoogleSignIn#hasPermissions(com.google.android.gms.auth.api.signin.GoogleSignInAccount,%20com.google.android.gms.common.api.Scope...)

And on iOS:

https://developers.google.com/identity/sign-in/ios/reference/Classes/GIDGoogleUser#grantedscopes

As you suggested above, the token may be a web-only artifact, so I'm going to make it a completely optional, named parameter so it can be ignored by other implementations if you ever need to implement this other than "isSignedIn".

packages/google_sign_in/google_sign_in_web/example/pubspec.yaml

ditman · 2023-03-28T22:10:06Z

Someone other than me will need to review the actual web parts.

I'll find somebody to review the web bits as well. Thanks for the rest of the review, I'll correct everything by EOD today.

Also, add comments to the example app, so its flow is easier to follow.

ditman · 2023-03-30T21:57:45Z

Rather than rebasing this branch, I'll start creating the independent PRs off of the latest master.

ditman · 2023-04-06T23:26:55Z

This has been published as google_sign_in: ^6.1.0:

https://pub.dev/packages/google_sign_in/changelog#610

stuartmorgan-g · 2023-05-15T15:48:19Z

Please use the issue tracker to report issues; the PR is for reviewing the change before landing it (which has already happened).

github-actions bot added p: google_sign_in platform-web labels Mar 15, 2023

This was referenced Mar 15, 2023

[google_sign_in_web] Migrate from Google Sign-In JavaScript Platform Library to Google Identity Services flutter/flutter#88084

Closed

[google_sign_in_web] Display Sign In With Google button flutter/flutter#121781

Closed

ditman mentioned this pull request Mar 15, 2023

Build dashboard sign in silently is failing flutter/flutter#121275

Closed

c-seeger reviewed Mar 15, 2023

View reviewed changes

packages/google_sign_in/google_sign_in_web/lib/src/button_configuration.dart Show resolved Hide resolved

packages/google_sign_in/google_sign_in_web/example/lib/button_tester.dart Outdated Show resolved Hide resolved

c-seeger reviewed Mar 15, 2023

View reviewed changes

packages/google_sign_in/google_sign_in/example/lib/main.dart Outdated Show resolved Hide resolved

ditman force-pushed the gsi-web-add-button branch 2 times, most recently from e41ad8f to 6e211e5 Compare March 16, 2023 03:57

ditman force-pushed the gsi-web-add-button branch 4 times, most recently from ed73491 to 3b14f63 Compare March 18, 2023 06:28

ditman marked this pull request as ready for review March 21, 2023 01:45

ditman requested a review from stuartmorgan-g as a code owner March 21, 2023 01:45

stuartmorgan-g reviewed Mar 27, 2023

View reviewed changes

ditman added 9 commits March 28, 2023 16:09

[gsi_interface] Introduces 'canAccessScopes' and 'userDataEvents'.

32a3619

[google_sign_in] Exposes new 'canAccessScopes' method.

b5cda64

[gsi_web] Adds renderButton and more.

99e3d47

[gsi_web] Adds button_tester example app.

d54fc07

[google_sign_in] Update example to the latest API.

473fd1c

[google_sign_in] Hide sign_in_button behind a conditional import.

6a991bc

[gsi_web] Appease analyzer.

fecd765

[gis_web] Tidy up flex view. Add integration tests.

92b6b92

[gis_web] Update mockito mocks after update.

04a873e

ditman added 2 commits March 28, 2023 16:09

[google_sign_in] Use the correct token to check for authorization.

dbf5fe4

Also, add comments to the example app, so its flow is easier to follow.

[gsi_web] Add integration tests for new methods.

9a4242a

ditman force-pushed the gsi-web-add-button branch from d3ebcac to 9a4242a Compare March 28, 2023 23:10

ditman added 3 commits March 28, 2023 19:12

[gsi_interface] Tweak canAccessScopes API.

73ce2fd

[gsi_web] Conform to interface. Cleanup.

6e97ac7

[google_sign_in] Update to the new API. Cleanup and docs.

e97d5e4

ditman force-pushed the gsi-web-add-button branch from e251733 to e97d5e4 Compare March 29, 2023 17:50

This was referenced Apr 3, 2023

[gsi_interface] Introduces canAccessScopes and userDataEvents. #3635

Merged

[gsi_web] Adds Sign In button. #3636

Merged

[google_sign_in] Adds Google Sign In button (web). #3642

Merged

stuartmorgan-g mentioned this pull request Apr 5, 2023

[google_sign_in] Implement canAccessScopes on mobile flutter/flutter#124206

Closed

auto-submit bot closed this in #3642 Apr 6, 2023

This comment was marked as off-topic.

Sign in to view

[google_sign_in] Adds "Button" Sign In for Web. #3461

[google_sign_in] Adds "Button" Sign In for Web. #3461

Uh oh!

Conversation

ditman commented Mar 15, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Issues

Testing

Pre-launch Checklist

Uh oh!

ditman commented Mar 15, 2023

Uh oh!

c-seeger left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ditman commented Mar 16, 2023

Uh oh!

ditman commented Mar 21, 2023

Uh oh!

SeriousMonk commented Mar 26, 2023

Uh oh!

stuartmorgan-g left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

stuartmorgan-g Mar 27, 2023

Choose a reason for hiding this comment

Uh oh!

ditman Mar 28, 2023

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g Mar 27, 2023

Choose a reason for hiding this comment

Uh oh!

ditman Mar 28, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ditman commented Mar 28, 2023

Uh oh!

ditman commented Mar 30, 2023

Uh oh!

ditman commented Apr 6, 2023

Uh oh!

This comment was marked as off-topic.

stuartmorgan-g commented May 15, 2023

Uh oh!

Uh oh!

ditman commented Mar 15, 2023 •

edited

Loading