Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/packages
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 53ed5a0aa9e4
Choose a base ref
...
head repository: flutter/packages
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: cdae854a59b9
Choose a head ref
  • 9 commits
  • 96 files changed
  • 5 contributors

Commits on Jun 30, 2023

  1. Roll Flutter from 51bef1b to ff838bc (12 revisions) (#4346) 

    flutter/flutter@51bef1b...ff838bc

2023-06-29 thkim1011@users.noreply.github.com Add locale-specific
DateTime formatting syntax (flutter/flutter#129573)
2023-06-29 tessertaha@gmail.com Update `RadioListTile` tests to M3
(flutter/flutter#129718)
2023-06-29 engine-flutter-autoroll@skia.org Roll Flutter Engine from
7fd0e9522ea1 to eabb22900b44 (1 revision) (flutter/flutter#129754)
2023-06-29 engine-flutter-autoroll@skia.org Roll Flutter Engine from
d5c25ead07e9 to 7fd0e9522ea1 (2 revisions) (flutter/flutter#129752)
2023-06-29 tjtanjia.tan@gmail.com Fix typos in ListTile examples.
(flutter/flutter#129606)
2023-06-29 engine-flutter-autoroll@skia.org Roll Flutter Engine from
4e49b9deb72d to d5c25ead07e9 (7 revisions) (flutter/flutter#129750)
2023-06-29 engine-flutter-autoroll@skia.org Roll Flutter Engine from
241ca5c1d6be to 4e49b9deb72d (1 revision) (flutter/flutter#129730)
2023-06-29 jacksongardner@google.com Skwasm benchmarks.
(flutter/flutter#129681)
2023-06-28 jmccandless@google.com RTL InputDecoration fix
(flutter/flutter#129661)
2023-06-28 christopherfujino@gmail.com mark autoroller flaky
(flutter/flutter#129745)
2023-06-28 fluttergithubbot@gmail.com Roll pub packages
(flutter/flutter#129380)
2023-06-28 109253501+pdblasi-google@users.noreply.github.com Removes
deprecated APIs from AnimationBuilder (flutter/flutter#129657)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC
camillesimon@google.com,rmistry@google.com,stuartmorgan@google.com on
the revert to ensure that a human
is aware of the problem.

To file a bug in Packages:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

---------

Co-authored-by: Camille Simon <43054281+camsim99@users.noreply.github.com>
    @engine-flutter-autoroll @camsim99
    engine-flutter-autoroll and camsim99 authored Jun 30, 2023
    Configuration menu
    Copy the full SHA
    8522793 View commit details
    Browse the repository at this point in the history

  2. [shared_preferences] Adds allowList to setPrefix method. (#3794) 

    Creates optional allow list for preference keys when setting custom prefix.

Also makes integration tests more homogenous across platforms. 

Fixes flutter/flutter#128948
    @tarrinneal
    tarrinneal authored Jun 30, 2023
    Configuration menu
    Copy the full SHA
    03c73a6 View commit details
    Browse the repository at this point in the history

  3. Prepare for utf8.encode() to return more precise Uint8List type (#4342) 

    To avoid analyzer warnings when `utf8.encode()` will return the more precise `Uint8List` type, we use `const Utf8Encoder().convert()` which already returns `Uint8List`

See dart-lang/sdk#52801
    @mkustermann
    mkustermann authored Jun 30, 2023
    Configuration menu
    Copy the full SHA
    cbbc2fb View commit details
    Browse the repository at this point in the history

  4. [camera_android] Support concurrently image capture and image streami… 

    …ng (#4332)

Properly configures surface needed for image capture when image streaming/recording is started to support concurrently still capture and image streaming.

Fixes flutter/flutter#125314.

Apologies for the many commits :(
    @camsim99
    camsim99 authored Jun 30, 2023
    Configuration menu
    Copy the full SHA
    d6e0d1f View commit details
    Browse the repository at this point in the history

  5. [Pigeon] readme updates (#3705) 

    Updates README's to better reflect modern pigeon and it's usage. 
Very open to feedback on this, please let me know what could be better, clearer, or is just missing from this documentation.
I don't expect to be able to cover all uses with this, if people want to see all possibilities, I think looking into our very thorough integration tests will provide them with anything they could need (all of which is linked in the example README).

fixes flutter/flutter#66511
partial work for flutter/flutter#123851
fixes flutter/flutter#108531
fixes flutter/flutter#92641
    @tarrinneal
    tarrinneal authored Jun 30, 2023
    Configuration menu
    Copy the full SHA
    d3c0d5f View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2023

  1. [google_sign_in] Convert Android to Pigeon (#4344) 

    Replaces the direct method channel implementation with Pigeon.

Since `google_sign_in`, unlike most of our plugins, exposes an API that's intended for direct cross-plugin native use, the existing methods are all left in place, but refactored as passthroughs to the new Pigeon versions. To ensure that they aren't broken, the existing Java tests are preserved unchanged (as a "legacy" copy) with `onMethodCall` left in place for now just to allow the tests to continue to run as-is. Since that dispatches to the legacy methods, this keeps the existing coverage of those methods.

The new tests are a copy of the legacy tests, minimally translated to use the new Pigeon variants, to ensure continuity of testing to the new version.

Part of flutter/flutter#117908
    @stuartmorgan-g
    stuartmorgan-g authored Jul 1, 2023
    Configuration menu
    Copy the full SHA
    6ab9a8b View commit details
    Browse the repository at this point in the history

  2. [file_selector] Endorse Android (#4329) 

    Endorses the new Android implementation of `file_selector`, updating the README accordingly.

Also adjusts the example to better handle platform diffs, by hiding UI that doesn't work instead of just labelling it on the button. Left a TODO to improve how we determine what to hide once we have the API to do so.

Fixes flutter/flutter#110098
    @stuartmorgan-g
    stuartmorgan-g authored Jul 1, 2023
    Configuration menu
    Copy the full SHA
    41d5ca9 View commit details
    Browse the repository at this point in the history

  3. [tool] Add a flag to skip cleanup (#4357) 

    It can be useful in debugging snippet setup to look at the extraction output, but the tool cleans that up automatically. Running the extraction manually is complicated due to the on-the-fly pubspec modifications, so this adds a `--no-cleanup` flag that can be used to skip the deletion of the extraction output, and instead log its location to the terminal.
    @stuartmorgan-g
    stuartmorgan-g authored Jul 1, 2023
    Configuration menu
    Copy the full SHA
    8b3b1ef View commit details
    Browse the repository at this point in the history

  4. Roll Flutter from ff838bc to aa5f4a2 (29 revisions) (#4363) 

    flutter/flutter@ff838bc...aa5f4a2

2023-07-01 goderbauer@google.com Enable no_wildcard_variable_uses lint (flutter/flutter#129858)
2023-06-30 christopherfujino@gmail.com mark packages-autoroller bringup again (flutter/flutter#129859)
2023-06-30 36861262+QuncCccccc@users.noreply.github.com Update `SwitchTheme` tests for M2/M3 (flutter/flutter#129811)
2023-06-30 christopherfujino@gmail.com Change pub roller bot to push to flutter-pub-roller-bot/flutter.git (flutter/flutter#129844)
2023-06-30 greg@zulip.com Fix NetworkImage causing spurious warning in tests (flutter/flutter#129537)
2023-06-30 engine-flutter-autoroll@skia.org Roll Flutter Engine from 54b573e9c4e5 to e6b8292705a8 (4 revisions) (flutter/flutter#129852)
2023-06-30 34871572+gmackall@users.noreply.github.com Upgrade integration tests to use AGP 7.3/Gradle 7.4 (flutter/flutter#129642)
2023-06-30 engine-flutter-autoroll@skia.org Roll Packages from d4752c4 to 53ed5a0 (5 revisions) (flutter/flutter#129837)
2023-06-30 32242716+ricardoamador@users.noreply.github.com Updated correct tasks for test ownership fix (flutter/flutter#129812)
2023-06-30 hans.muller@gmail.com Updated some golden image tests for M2/M3 (flutter/flutter#129794)
2023-06-30 nbosch@google.com Remove an unnecessary assert (flutter/flutter#129796)
2023-06-30 36861262+QuncCccccc@users.noreply.github.com Update `Radio` tests for M2/M3 (flutter/flutter#129814)
2023-06-30 36861262+QuncCccccc@users.noreply.github.com Update `Switch` tests for M2/M3 (flutter/flutter#129810)
2023-06-30 engine-flutter-autoroll@skia.org Roll Flutter Engine from 099a70ebbc60 to 54b573e9c4e5 (1 revision) (flutter/flutter#129821)
2023-06-30 36861262+QuncCccccc@users.noreply.github.com Update `SwitchListTile` tests for M2/M3 (flutter/flutter#129809)
2023-06-30 tessertaha@gmail.com Fix `NavigationDrawer` selected item has wrong icon color (flutter/flutter#129625)
2023-06-30 leroux_bruno@yahoo.fr Update basic_test.dart for M3 compliance (flutter/flutter#129714)
2023-06-30 engine-flutter-autoroll@skia.org Roll Flutter Engine from d33343430f18 to 099a70ebbc60 (7 revisions) (flutter/flutter#129818)
2023-06-30 engine-flutter-autoroll@skia.org Roll Flutter Engine from 68cc1a7971d5 to d33343430f18 (2 revisions) (flutter/flutter#129801)
2023-06-30 godofredoc@google.com Revert no-response to fork. (flutter/flutter#129775)
2023-06-30 36861262+QuncCccccc@users.noreply.github.com Make `DropdownMenu` be able to scroll to the highlighted item when searching. (flutter/flutter#129740)
2023-06-29 engine-flutter-autoroll@skia.org Roll Flutter Engine from cd9ce66db14a to 68cc1a7971d5 (10 revisions) (flutter/flutter#129799)
2023-06-29 49699333+dependabot[bot]@users.noreply.github.com Bump actions/labeler from 4.1.0 to 4.2.0 (flutter/flutter#129797)
2023-06-29 engine-flutter-autoroll@skia.org Roll Flutter Engine from eabb22900b44 to cd9ce66db14a (1 revision) (flutter/flutter#129756)
2023-06-29 5236035+fzyzcjy@users.noreply.github.com Remove `@NonNull` to avoid warning (flutter/flutter#129472)
2023-06-29 32242716+ricardoamador@users.noreply.github.com Remove use of any (flutter/flutter#129793)
2023-06-29 kustermann@google.com Prepare for utf8.encode() to return more precise Uint8List type (flutter/flutter#129769)
2023-06-29 lsaudon@gmail.com Deletes files that should be ignored (flutter/flutter#127984)
2023-06-29 christopherfujino@gmail.com Fix flutter_plugins by rolling revision (flutter/flutter#129781)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC dit@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @engine-flutter-autoroll
    engine-flutter-autoroll authored Jul 1, 2023
    Configuration menu
    Copy the full SHA
    cdae854 View commit details
    Browse the repository at this point in the history
Loading