Skip to content

Revert "Bump ndk" #669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 22, 2021
Merged

Revert "Bump ndk" #669

merged 1 commit into from
Jan 22, 2021

Conversation

domesticmouse
Copy link
Contributor

Reverts #662

Looks like the Github Action platform has reverted the available NDK version: https://github.com/flutter/samples/pull/668/checks?check_run_id=1746329483#step:5:418

This was referenced Jan 22, 2021
Merged
Merged
goderbauer
goderbauer approved these changes Jan 22, 2021
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol, we should find a way to stabilize this. Can we pin the version that's available or something like that?

LGTM

@domesticmouse domesticmouse merged commit 5308328 into master Jan 22, 2021
@domesticmouse domesticmouse deleted the revert-662-bumpNDK branch January 22, 2021 20:08
@domesticmouse
Copy link
Contributor Author

@godofredoc I don't see the ability to pin GitHub actions to a specific revision.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goderbauer goderbauer goderbauer approved these changes

@johnpryan johnpryan Awaiting requested review from johnpryan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@domesticmouse @goderbauer