Skip to content

Initialize the Skia client more efficiently #95055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 11, 2021
Merged

Initialize the Skia client more efficiently #95055

merged 4 commits into from
Dec 11, 2021

Conversation

Piinks
Copy link
Contributor

@Piinks Piinks commented Dec 10, 2021

Might fix #94729
Also tracked in https://bugs.chromium.org/p/skia/issues/detail?id=12717

This moves the call to initialize into the compare method of the Flutter[Pre/Post]SubmitFileComparators. Calling it in the constructor means we might be initializing when there are no image tests being executed.

It also adds a flag to keep track of whether or not an instance of the skia client has been initialized, so we can just skip it in that case too.

Also tidied up a bit while I was at it.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@Piinks Piinks added a: tests "flutter test", flutter_test, or one of our tests c: contributor-productivity Team-specific productivity, code health, technical debt. team: flakes team: presubmit flakes Presubmit flakes found c: tech-debt Technical debt, code quality, testing, etc. infra: auto flake bot Issues with the bot that files flake issues labels Dec 10, 2021
@flutter-dashboard flutter-dashboard bot added the framework flutter/packages/flutter repository. See also f: labels. label Dec 10, 2021
@Piinks Piinks requested a review from dnfield December 10, 2021 23:46
@Piinks
Copy link
Contributor Author

Piinks commented Dec 10, 2021

FYI @kjlubick this should reduce traffic significantly. :)

@Piinks Piinks changed the title Init l ess Initialize the Skia client more efficiently Dec 10, 2021
@Piinks Piinks requested a review from goderbauer December 10, 2021 23:48
@Piinks Piinks mentioned this pull request Dec 10, 2021
Closed
@fluttergithubbot fluttergithubbot merged commit 895beb0 into flutter:master Dec 11, 2021
@kjlubick
Copy link
Contributor

I can confirm this has reduced traffic on the Gold side.

@Piinks
Copy link
Contributor Author

Piinks commented Dec 15, 2021

Sweet! Thanks!

@Piinks Piinks mentioned this pull request Jan 25, 2022
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goderbauer goderbauer Awaiting requested review from goderbauer

1 more reviewer

@dnfield dnfield dnfield approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
a: tests "flutter test", flutter_test, or one of our tests c: contributor-productivity Team-specific productivity, code health, technical debt. c: tech-debt Technical debt, code quality, testing, etc. framework flutter/packages/flutter repository. See also f: labels. infra: auto flake bot Issues with the bot that files flake issues team: presubmit flakes Presubmit flakes found
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Linux framework_tests_widgets is 2.00% flaky
4 participants
@Piinks @kjlubick @dnfield @fluttergithubbot