Skip to content

Conversation

DanTup
Copy link
Contributor

@DanTup DanTup commented Nov 29, 2021

I think this should fix #94030.

We usually throw (to fail tests) if there is output to stderr process or a non-zero exit code during a test run. However when we're running teardown code we generally don't want this (tests aren't guaranteed to leave things cleanly, they just finish when their expectations are met and allow the teardown code to terminate the process). There was code to allow non-zero exit codes during shutdown, but not stderr output.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Nov 29, 2021
@google-cla google-cla bot added the cla: yes label Nov 29, 2021
@Hixie
Copy link
Contributor

Hixie commented Nov 29, 2021

test-exempt: fixes flaky test.

though the precommits don't agree. :-)

@DanTup
Copy link
Contributor Author

DanTup commented Nov 29, 2021

though the precommits don't agree. :-)

heh. I think they may be different (they look unrelated to this test) and wondered if they were related to the tree being red. I'll rebase once the tree is fixed and run them a few times to check it all looks good. Thanks!

Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DanTup
Copy link
Contributor Author

DanTup commented Nov 30, 2021

There are still some flakes here, but they seem unrelated to this change (or the flake it tries to fix), and look like the issue being tracked in #92042 (comment).

So I'll re-run this until it's green (and verify the only flakes I see in the meantime are not the one this aims to fix) and then land when the tree is open.

NoSuchMethodError: The getter 'uri' was called on null.
Receiver: null
Tried calling: uri
#0      Object.noSuchMethod (dart:core-patch/object_patch.dart:68:5)
#1      ResidentRunner.printDebuggerList (package:flutter_tools/src/resident_runner.dart:1393:47)
#2      FlutterResidentDevtoolsHandler.serveAndAnnounceDevTools (package:flutter_tools/src/resident_devtools_handler.dart:96:23)
<asynchronous suspension>

@fluttergithubbot fluttergithubbot merged commit b865e23 into flutter:master Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Linux tool_integration_tests_3_4 is 2.00% flaky
4 participants