Skip to content

Use ColorScheme.primary (not secondary), ExpansionTile expanded color #81241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 27, 2021
Merged

Use ColorScheme.primary (not secondary), ExpansionTile expanded color #81241

merged 1 commit into from
Apr 27, 2021

Conversation

HansMuller
Copy link
Contributor

@HansMuller HansMuller commented Apr 26, 2021 •
edited
Loading

ExpansionTile should use ColorScheme.primaryColor by default for expanded titles and icons, as ListTile does.

Applications can override this using ExpansionTile's iconColor and textColor properties: see #78281

Fixes #80968
Tested in (internal Google link) cl/370548778

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Apr 26, 2021
@google-cla google-cla bot added the cla: yes label Apr 26, 2021
@HansMuller HansMuller requested a review from darrenaustin April 26, 2021 22:30
@HansMuller HansMuller mentioned this pull request Apr 26, 2021
Closed
darrenaustin
darrenaustin approved these changes Apr 26, 2021
View reviewed changes
Copy link
Contributor

@darrenaustin darrenaustin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HansMuller HansMuller merged commit 3533321 into flutter:master Apr 27, 2021
@HansMuller HansMuller mentioned this pull request Apr 27, 2021
Closed
19 tasks
@HansMuller HansMuller deleted the expansion_tile_expanded_color branch April 27, 2021 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@darrenaustin darrenaustin darrenaustin approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ListTile and ExpansionTile color scheme
2 participants
@HansMuller @darrenaustin