[State Restoration] Restorable TimePickerDialog widget, RestorableTimeOfDay
#80566
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimePickerDialog widget, RestorableTimeOfDay
goderbauer
approved these changes
Apr 22, 2021
Comment on lines
169
to
172
| Object? toPrimitives() => <String, int>{ | ||
| 'minute': value.minute, | ||
| 'hour': value.hour, | ||
| }; |
There was a problem hiding this comment.
We could eliminate the keys and just store this as:
Suggested change
| Object? toPrimitives() => <String, int>{ | |
| 'minute': value.minute, | |
| 'hour': value.hour, | |
| }; | |
| Object? toPrimitives() => <int>[value.minute, value.hour]; |
... with a corresponding change in fromPrimitives.
Comment on lines
1652
to
1659
| @override | ||
| String? get restorationId => widget.restorationId; | ||
|
|
||
| @override | ||
| void restoreState(RestorationBucket? oldBucket, bool initialRestore) { | ||
| registerForRestoration(controller, 'text_editing_controller'); | ||
| registerForRestoration(controllerHasBeenSet, 'has_controller_been_set'); | ||
| } |
There was a problem hiding this comment.
nit: let's move these below the block of field declarations below.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #80564.
TimePickerDialogand adding state restoration framework support.RestorableTimeOfDayclass that is helpful when used in tandem withTimePickerDialog.Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.