Skip to content

Skip flaky golden file test #87589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 3, 2021
Merged

Skip flaky golden file test #87589

merged 1 commit into from
Aug 3, 2021

Conversation

Piinks
Copy link
Contributor

@Piinks Piinks commented Aug 3, 2021

This skips the animation.LiveBinding.press.animation golden file test. It is still flaky after several reverts and relands. The other related test is stable, so I am skipping this one for now until it can be addressed. See linked issue for more context.

Related issue: #87588

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@Piinks Piinks added a: tests "flutter test", flutter_test, or one of our tests c: contributor-productivity Team-specific productivity, code health, technical debt. framework flutter/packages/flutter repository. See also f: labels. team: flakes c: tech-debt Technical debt, code quality, testing, etc. labels Aug 3, 2021
@Piinks Piinks requested review from goderbauer and dkwingsmt August 3, 2021 20:35
@google-cla google-cla bot added the cla: yes label Aug 3, 2021
@Piinks Piinks mentioned this pull request Aug 3, 2021
Open
dkwingsmt
dkwingsmt approved these changes Aug 3, 2021
View reviewed changes
Copy link
Contributor

@dkwingsmt dkwingsmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, sorry for the trouble.

@Piinks
Copy link
Contributor Author

Piinks commented Aug 3, 2021

No trouble at all! Just flakes. :)

@fluttergithubbot fluttergithubbot merged commit 1a76a01 into flutter:master Aug 3, 2021
@yjbanov yjbanov mentioned this pull request Sep 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkwingsmt dkwingsmt dkwingsmt approved these changes

@goderbauer goderbauer Awaiting requested review from goderbauer

Assignees
No one assigned
Labels
a: tests "flutter test", flutter_test, or one of our tests c: contributor-productivity Team-specific productivity, code health, technical debt. c: tech-debt Technical debt, code quality, testing, etc. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Piinks @dkwingsmt @fluttergithubbot