Add tests for integration tests to devicelab #79258
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonahwilliams
approved these changes
Mar 30, 2021
|
https://flutter-dashboard.appspot.com/#/build shows that the entire row for this commit is green, but I would have expect a new column to be added for this change, since new tests are added. Am I doing something wrong here? https://github.com/flutter/flutter/blob/master/dev/devicelab/README.md seems to be a bit out of date with |
|
You'll need to update https://cs.opensource.google/flutter/infra/+/master:config/devicelab_config.star;bpv=1 to dedicate infrastructure to run these tasks. This PR only added UI to show the infrastructure. Adding the task name to |
|
Will do, opened https://github.com/flutter/infra/pull/401 for this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Device lab tests for #76200
Tested:
First patch #76200, and
cd dev/devicelab.Android:
iOS
Need to modify the runner to create a custom team and bundle ID first, then
Not sure if there's a way to test that the
prod_builders.jsonis correct locally, so I think the above should be good enough