Skip to content

Removed RefreshIndicator accentColor dependency. #77884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 11, 2021
Merged

Removed RefreshIndicator accentColor dependency. #77884

merged 1 commit into from
Mar 11, 2021

Conversation

darrenaustin
Copy link
Contributor

This PR removes the RefreshIndicator widget's accentColor dependency per #56918.

The RefreshIndicator widget's color property used the ThemeData.accentColor by default. This PR updates it to use the ColorScheme.primary instead.

Breaking change

This is a breaking change. For apps that need a specific color for their RefreshIndicators they can just pass it into the constructor for the widget:

  RefreshIndicator(
    color: Colors.yellow,
     ...
  )

A new test was added to check verify the default RefreshIndicator color is now ColorScheme.primary.

This PR was tested against internal Google apps in cl/360775206.

@darrenaustin darrenaustin added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Mar 11, 2021
@darrenaustin darrenaustin requested a review from HansMuller March 11, 2021 07:08
@google-cla google-cla bot added the cla: yes label Mar 11, 2021
@darrenaustin darrenaustin mentioned this pull request Mar 11, 2021
Closed
19 tasks
HansMuller
HansMuller approved these changes Mar 11, 2021
View reviewed changes
Copy link
Contributor

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot fluttergithubbot merged commit aec2985 into flutter:master Mar 11, 2021
@darrenaustin darrenaustin deleted the accent_refreshindicator branch April 26, 2021 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@HansMuller HansMuller HansMuller approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@darrenaustin @HansMuller @fluttergithubbot