Skip to content

Conversation

HansMuller
Copy link
Contributor

For tiles with selected: true, if the tile's activeColor is null, the selected item's text color now defaults to ThemeData.toggleableActiveColor instead of ThemeData.accentColor. This removes the widget's accentColor dependency per #56918.

This is technically not a breaking change, because it doesn't break any existing tests. However the dependency had been documented.

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Feb 27, 2021
@google-cla google-cla bot added the cla: yes label Feb 27, 2021
@HansMuller HansMuller force-pushed the remove_accent_color_in_radio_list_tile branch from b38faf5 to 84e0ab3 Compare February 27, 2021 02:26
Copy link
Contributor

@darrenaustin darrenaustin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HansMuller HansMuller merged commit 0478cbe into flutter:master Mar 1, 2021
@HansMuller HansMuller deleted the remove_accent_color_in_radio_list_tile branch March 1, 2021 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants