Skip to content

Remove dead mock classes #75757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 11, 2021
Merged

Remove dead mock classes #75757

merged 1 commit into from
Feb 11, 2021

Conversation

jmagman
Copy link
Member

@jmagman jmagman commented Feb 10, 2021 •
edited
Loading

  • Remove dead mocks
  • MockProcessManager -> FakeProcessManager in web_test
  • MockPlatform -> FakePlatform in flutter_platform_test
  • MockAnsiTerminal -> Terminal.test() in xcodeproj_test

Part of #71511

@jmagman jmagman added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Feb 10, 2021
@jmagman jmagman self-assigned this Feb 10, 2021
@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Feb 10, 2021
@google-cla google-cla bot added the cla: yes label Feb 10, 2021
jonahwilliams
jonahwilliams approved these changes Feb 10, 2021
View reviewed changes
Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, yes gooood

LGTM!

@jmagman jmagman merged commit 5b823cd into flutter:master Feb 11, 2021
@jmagman jmagman deleted the mocks branch February 11, 2021 01:01
@jiahaog jiahaog mentioned this pull request Feb 16, 2021
Merged
@jmagman jmagman added the c: tech-debt Technical debt, code quality, testing, etc. label Aug 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@jonahwilliams jonahwilliams jonahwilliams approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@jmagman jmagman

Labels
c: contributor-productivity Team-specific productivity, code health, technical debt. c: tech-debt Technical debt, code quality, testing, etc. tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmagman @jonahwilliams